ci(PLAY-1498 ): migrate CI to GitHub Actions and publish npm on releases - #114
Merged
Merged
Conversation
- Port CircleCI test job to pr.yml (npm ci, tsc, lint, build) - Rename PR title lint workflow to semantic-pr.yml (flowplayer-native naming) - Add reusable release-channel.yml: npm publish on released (latest) / prereleased (next) events, with workflow_dispatch backfill and dry_run - Exercise the publish pipeline on every PR via a release-dry-run job - Remove .circleci; S3 publishing of translations is handled elsewhere PLAY-1498 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
maximzavadskiy
changed the title
The dry-run already validated the publish pipeline on the initial PR run; keep the dry_run input on release-channel for future manual debugging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates CI from CircleCI to GitHub Actions and adds a GitHub Actions-based release pipeline to publish @flowplayer/translations to npm when GitHub Releases are created.
Changes:
- Replaces the CircleCI PR build/lint pipeline with a
pr.ymlGitHub Actions workflow (Node 20,npm ci, lint, build). - Adds PR title linting via a dedicated
semantic-pr.ymlworkflow. - Adds a reusable
release-channel.ymlworkflow, wired byreleased.yml/prereleased.yml, to publish stable (latest) and canary (next) tags to npm.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr.yml | Runs install/lint/build on pull requests using GitHub Actions. |
| .github/workflows/semantic-pr.yml | Validates semantic PR titles via action-semantic-pull-request. |
| .github/workflows/release-channel.yml | Reusable workflow to validate tag/version and publish to npm. |
| .github/workflows/released.yml | Triggers stable npm publish on GitHub “released” events. |
| .github/workflows/prereleased.yml | Triggers canary npm publish on GitHub “prereleased” events. |
| .circleci/config.yml | Removes CircleCI configuration. |
Comments suppressed due to low confidence (1)
.github/workflows/release-channel.yml:63
NPM_TOKENis marked as optional (to support dry runs), but the workflow always writes it into~/.npmrc. When the secret is unset this will write an empty auth token, which can breaknpm ci/npm publishand also makes real publishes fail later with an auth error. Configure npm auth only whendry_runis false, and fail early if the token is missing.
- uses: actions/setup-node@v4
with:
node-version: 20
cache: "npm"
- run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bbbo
approved these changes
Jul 28, 2026
bbbo
left a comment
bbbo
left a comment
Member
There was a problem hiding this comment.
LGTM as far as I understand the code ;)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements PLAY-1498 (epic PLAY-1313 UI Redesign).
Changes
testjob to GitHub Actions (pr.yml): Node 20,npm ciwith caching,tsc --version,npm run lint,npm run buildon every pull request.semantic-pr.yml, matching flowplayer-native naming.package.jsonversion matches the tag, then publishes@flowplayer/translationsto npm.releasedevent → dist-taglatest(via released.yml)prereleasedevent → dist-tagnext(via prereleased.yml)workflow_dispatchwithtag/channel/dry_runinputs for manual runs, backfills, and debugging (dry_runruns the full pipeline withnpm publish --dry-run).circleci/entirely. The S3 sync ofdist/is intentionally not ported — AWS publishing of translations is handled elsewhere.The publish pipeline was verified end-to-end on this PR via a temporary
release-dry-runjob (checkout v2.7.0 → version guard →npm ci→npm publish --tag=next --dry-run): passing run. The job was removed after verification; thedry_runinput remains for future debugging.Manual follow-ups after merge
NPM_TOKENrepo secret (npm automation token with publish rights to@flowplayer/translations).latest= 2.6.0, GitHub is at v2.7.0): run therelease-channelworkflow withtag=v2.7.0,channel=stable.🤖 Generated with Claude Code